Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upChange locale of mdspell to en-US #7671
+704
−1,003
Conversation
adityapatwardhan
requested review from
rjmholt and
TravisEz13
Aug 30, 2018
adityapatwardhan
requested review from
anmenaga,
dantraMSFT and
daxian-dbw
as
code owners
Aug 30, 2018
anmenaga
approved these changes
Aug 30, 2018
This comment has been minimized.
This comment has been minimized.
|
Looks like Travis is failing because of the spellcheck. Maybe worth regenerating the spelling exceptions file for this PR? |
adityapatwardhan
force-pushed the
adityapatwardhan:FixMdSpellLocale
branch
2 times, most recently
Aug 30, 2018
TravisEz13
reviewed
Aug 31, 2018
.spelling Outdated
TravisEz13
approved these changes
Aug 31, 2018
adityapatwardhan
added some commits
Aug 30, 2018
adityapatwardhan
force-pushed the
adityapatwardhan:FixMdSpellLocale
branch
to
c4a14cc
Aug 31, 2018
TravisEz13
merged commit d487ff9
into
PowerShell:master
Aug 31, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7671-20180831.04 succeeded with issues
Details
PowerShell-CI-macos
#PR-7671-20180831.04 succeeded
Details
PowerShell-CI-windows
#PR-7671-20180831.04 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
All CLA requirements met.
Details
adityapatwardhan
deleted the
adityapatwardhan:FixMdSpellLocale
branch
Sep 4, 2018
TravisEz13
added a commit
that referenced
this pull request
Sep 5, 2018
TravisEz13
added this to the v6.1.0 milestone
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
adityapatwardhan commentedAug 30, 2018
•
edited
Fix #6736
PR Summary
Update the locale to use en-us for mdspell checker.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests