Fix disposing of powershell in TypeInferenceContext if it was created…
… internally.

… internally.
Adding a PropertyNameCompleter custom completer.
PowerShell · daxian-dbw · Nov 14, 2018 · daxian-dbw · Nov 14, 2018 · powercode
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+    /// </summary>
+    [Cmdlet(VerbsCommon.Join, "Object", RemotingCapability = RemotingCapability.None, DefaultParameterSetName = "default")]
+    [OutputType(typeof(string))]
+    public class JoinObjectCommand : PSCmdlet
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+    public class JoinObjectCommand : PSCmdlet
+    {
+        // ReSharper disable once CollectionNeverQueried.Local
+        private readonly List<PSObject> _inputObjects = new List<PSObject>(50);
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+namespace Microsoft.PowerShell.Commands.Utility
+{
+    /// <summary>
+    /// Group-Object implementation.
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+
+            if (PropertyName == null)
+            {
+                if (_inputObjects.Count > 0)
diff --git a/...m.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs b/...m.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
diff --git a/...m.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs b/...m.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
diff --git a/...m.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs b/...m.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
diff --git a/src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs b/src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
        private readonly PowerShell _powerShell;

        public TypeInferenceContext()
        : this(PowerShell.Create(RunspaceMode.CurrentRunspace))
        {
+            _ownsPowerShell = true;
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+            CommandAst commandAst,
+            IDictionary fakeBoundParameters)
+        {
+            var res = new List<CompletionResult>(10);
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Utility/Join-Object.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Utility/Join-Object.Tests.ps1
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+        /// </summary>
+        [Parameter(Position = 0)]
+        [ArgumentCompleter(typeof(PropertyNameCompleter))]
+        public object PropertyName { get; set; }
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+                    case "\r": return "`r";
+                    case "\n": return "`n";
+                    case "\r\n": return "`r`n";
+                    default: return Environment.NewLine.Replace("\r", "`r").Replace("\n", "`n");
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-object.cs
+            CommandAst commandAst,
+            IDictionary fakeBoundParameters)
+        {
+            var res = new List<CompletionResult>(10);
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs
+
+        /// <summary>
+        /// Gets or sets a format string that is applied to each input object.
+        /// </summary>
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs
+    [OutputType(typeof(string))]
+    public sealed class JoinStringCommand : PSCmdlet
+    {
+        /// <summary>A bigger default to not get re-allocations in common use cases.</summary>
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs
+                {
+                    _outputBuilder.Append(_quoteChar);
+                    _outputBuilder.Append(stringValue);
+                    _outputBuilder.Append(_quoteChar);
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs
+                }
+                else
+                {
+                    _outputBuilder.AppendFormat(CultureInfo.CurrentCulture, FormatString, stringValue);
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/join-string.cs
+            get
+            {
+#if UNIX
+                return Platform.IsMacOS ? "`r" : "`n";
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Utility/Join-String.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Utility/Join-String.Tests.ps1
+
+    It "Should be called using an object as piped without error with no switches" {
+        {$testObject | Join-String } | Should -Not -Throw
+    }