Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove SuspendJob and ResumeJob cmdlets from compilation #7650
Conversation
JamesWTruher
requested a review
from
daxian-dbw
Aug 28, 2018
JamesWTruher
requested review from
adityapatwardhan,
anmenaga,
dantraMSFT and
TravisEz13
as
code owners
Aug 28, 2018
JamesWTruher
changed the title
Remove SuspendJob and ResumeJob sources from compilation
Remove SuspendJob and ResumeJob cmdlets from compilation
Aug 28, 2018
adityapatwardhan
requested changes
Aug 28, 2018
| <Compile Remove="engine\remoting\commands\ConnectPSSession.cs" /> | ||
| <Compile Remove="engine\remoting\commands\CustomShellCommands.cs" /> |
This comment has been minimized.
This comment has been minimized.
adityapatwardhan
Aug 28, 2018
Member
The ItemGroup is specific to non-windows. I think we need to remove these for all platforms
This comment has been minimized.
This comment has been minimized.
adityapatwardhan
approved these changes
Aug 28, 2018
TravisEz13
approved these changes
Aug 29, 2018
TravisEz13
assigned
daxian-dbw
Aug 29, 2018
dantraMSFT
approved these changes
Aug 30, 2018
daxian-dbw
approved these changes
Aug 30, 2018
daxian-dbw
merged commit 6d74298
into
PowerShell:master
Aug 30, 2018
8 checks passed
CodeFactor
No issues found.
Details
PowerShell-CI-linux
#PR-7650-20180828.02 succeeded with issues
Details
PowerShell-CI-macos
#PR-7650-20180828.02 succeeded with issues
Details
PowerShell-CI-windows
#PR-7650-20180828.02 succeeded
Details
WIP
ready for review
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
license/cla
All CLA requirements met.
TravisEz13
added a commit
that referenced
this pull request
Aug 31, 2018
TravisEz13
added this to the v6.1.0 milestone
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
JamesWTruher commentedAug 28, 2018
The classes for the cmdlets are present but the Cmdlet attribute has been removed. There is no reason why we should be compiling these files, and it very slightly impacts our code coverage numbers.
This can be taken for 6.2, there is no reason to take it for 6.1
PR Summary
Remove SuspendJob and ResumeJob from compilation
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests