★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/pull/7630Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %F option to Get-Date -UFormat #7630

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@britishben
Copy link
Contributor

commented Aug 24, 2018

PR Summary

I got annoyed that Get-Date -UFormat '%F %T' did not work the same as date +'%F %T', so I've added that case now. Partial fix for issue #7341.

PR Checklist

@msftclas

This comment has been minimized.

Copy link

commented Aug 24, 2018

CLA assistant check
All CLA requirements met.

@iSazonov
Copy link
Collaborator

left a comment

@britishben Thanks for your contribution!

Show resolved Hide resolved ...Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Outdated
@chuanjiao10

This comment has been minimized.

Copy link

commented Sep 4, 2018

hi all:
The fully issue is here: #7341 .
It is fully, i confirm one by one. @britishben please have a look .

@britishben

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2018

Thanks @chuanjiao10 - I've taken out the 'P' case now, so the only one of your cases this would solve is the first:

PS /root> get-date -uformat %F ; date +%F
F
2018-07-24

Still, slow progress is better than no progress.

@britishben britishben changed the title WIP: Add two options (%F, %P) to Get-Date -UFormat WIP: Add one option (%F) to Get-Date -UFormat Sep 4, 2018

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2018

@britishben If you don't plan fix %P please update the PR description and remove WIP.

@britishben britishben changed the title WIP: Add one option (%F) to Get-Date -UFormat Add %F option to Get-Date -UFormat Sep 24, 2018

@britishben

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2018

@iSazonov Done - thanks for the reminder.

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2018

@britishben Please rebase to fix CIs.

@britishben

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2018

@iSazonov done, thanks - let me know if you need anything else from me.

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2018

Please update package reference to Markdig.Signed 0.15.2 (see failed test)

Microsoft.PowerShell.MarkdownRender.csproj reference to Markdig.Signed 0.15.2

@britishben

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2018

@iSazonov I've bumped up the number in src/Microsoft.PowerShell.MarkdownRender/Microsoft.PowerShell.MarkdownRender.csproj to see if that makes a difference, but that's not my error; Looks like a version change from https://github.com/lunet-io/markdig/ (got 15.3, expected 15.2).

You'll probably see the same on all your PRs.

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2018

@britishben Yes, it is not your error. We have a test to check package versions. If there is a new version the test fail. We already merged a PR with version updates. So you should rebase.

Add '%F' case to Get-Date -UFormat
Update tests to add %F
@britishben

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2018

@iSazonov Thanks - done that now.

@iSazonov iSazonov self-assigned this Sep 27, 2018

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2018

@anmenaga @TravisEz13 Please review the PR.

@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2018

@britishben Please open new issue in PowerSehll-Docs repo (or push PR there) to document the enhancement and add a link to the issue to the PR description.

@britishben britishben referenced this pull request Sep 27, 2018

Merged

Add Get-Date '%F' option #2959

2 of 9 tasks complete

@iSazonov iSazonov merged commit 39252b4 into PowerShell:master Oct 1, 2018

8 checks passed

CodeFactor 2 issues fixed.
Details
PowerShell-CI-linux #PR-7630-20180927.03 succeeded
Details
PowerShell-CI-macos #PR-7630-20180927.03 succeeded
Details
PowerShell-CI-spelling #PR-7630-20180927.03 succeeded
Details
PowerShell-CI-windows #PR-7630-20180927.03 succeeded
Details
WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
@iSazonov

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2018

@britishben Thanks for your contribution!

@britishben britishben deleted the britishben:get-date-bpm branch Oct 1, 2018

sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 14, 2018

sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 15, 2018

sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 16, 2018

sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Dec 5, 2018

sdwheeler added a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Dec 20, 2018

sdwheeler added a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 6, 2019

sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 11, 2019

sdwheeler pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 14, 2019

v-alje added a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Feb 1, 2019

sdwheeler added a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.