Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd %F option to Get-Date -UFormat #7630
Conversation
britishben
requested review from
dantraMSFT,
JamesWTruher and
PaulHigin
as
code owners
Aug 24, 2018
This comment has been minimized.
This comment has been minimized.
msftclas
commented
Aug 24, 2018
•
iSazonov
reviewed
Aug 24, 2018
|
@britishben Thanks for your contribution! |
...Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Outdated
This comment has been minimized.
This comment has been minimized.
chuanjiao10
commented
Sep 4, 2018
|
hi all: |
This comment has been minimized.
This comment has been minimized.
|
Thanks @chuanjiao10 - I've taken out the 'P' case now, so the only one of your cases this would solve is the first:
Still, slow progress is better than no progress. |
britishben
changed the title
WIP: Add two options (%F, %P) to Get-Date -UFormat
WIP: Add one option (%F) to Get-Date -UFormat
Sep 4, 2018
This comment has been minimized.
This comment has been minimized.
|
@britishben If you don't plan fix %P please update the PR description and remove WIP. |
britishben
changed the title
WIP: Add one option (%F) to Get-Date -UFormat
Add %F option to Get-Date -UFormat
Sep 24, 2018
This comment has been minimized.
This comment has been minimized.
|
@iSazonov Done - thanks for the reminder. |
This comment has been minimized.
This comment has been minimized.
|
@britishben Please rebase to fix CIs. |
This comment has been minimized.
This comment has been minimized.
|
@iSazonov done, thanks - let me know if you need anything else from me. |
This comment has been minimized.
This comment has been minimized.
|
Please update package reference to Markdig.Signed 0.15.2 (see failed test)
|
britishben
requested review from
adityapatwardhan,
anmenaga,
daxian-dbw and
TravisEz13
as
code owners
Sep 27, 2018
This comment has been minimized.
This comment has been minimized.
|
@iSazonov I've bumped up the number in src/Microsoft.PowerShell.MarkdownRender/Microsoft.PowerShell.MarkdownRender.csproj to see if that makes a difference, but that's not my error; Looks like a version change from https://github.com/lunet-io/markdig/ (got 15.3, expected 15.2). You'll probably see the same on all your PRs. |
This comment has been minimized.
This comment has been minimized.
|
@britishben Yes, it is not your error. We have a test to check package versions. If there is a new version the test fail. We already merged a PR with version updates. So you should rebase. |
This comment has been minimized.
This comment has been minimized.
|
@iSazonov Thanks - done that now. |
iSazonov
approved these changes
Sep 27, 2018
iSazonov
self-assigned this
Sep 27, 2018
This comment has been minimized.
This comment has been minimized.
|
@anmenaga @TravisEz13 Please review the PR. |
This comment has been minimized.
This comment has been minimized.
|
@britishben Please open new issue in PowerSehll-Docs repo (or push PR there) to document the enhancement and add a link to the issue to the PR description. |
iSazonov
added
the
Documentation Needed
label
Sep 27, 2018
iSazonov
merged commit 39252b4
into
PowerShell:master
Oct 1, 2018
8 checks passed
This comment has been minimized.
This comment has been minimized.
|
@britishben Thanks for your contribution! |
britishben commentedAug 24, 2018
•
edited
PR Summary
I got annoyed that
Get-Date -UFormat '%F %T'did not work the same asdate +'%F %T', so I've added that case now. Partial fix for issue #7341.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests