Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRound delay in call_later() #236
Conversation
|
If we want to respect the guarantee that the CB is called "no earlier than X", isn't ceil() more appropriate than round()? |
|
@jlaine replied in #233 (comment) |
|
Ok sorry for the duplicate message |
e81f90f
to
c486898
|
So is the new test stable? |
|
Yeah I think so |
|
Alright, merged. Thank you! :) |
|
@fantix got this CI failure this morning: Could you please take another look at the test? Is it possible to make it any more reliable? If not, I suggest we relax it a bit or drop it. |
|
(or maybe we should go with @jlaine suggestion to use |
|
@1st1 |
|
Let's try it... Would the old code (without |
|
@1st1 the old code may probably succeed with this test at |
|
Alright, I pushed e3b00b8 |
|
Oh, thanks for that! |

fantix commentedMar 17, 2019
•
edited