★ wanayoo — archive 1999 https://github.com/MagicStack/uvloop/pull/204Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise "requires a DNS lookup" error on Unix Domain Socket #204

Merged
merged 1 commit into from Oct 18, 2018

Conversation

@pax0r
Copy link
Contributor

pax0r commented Oct 13, 2018

This fixes #196

f = self.loop.create_datagram_endpoint(
lambda: MyDatagramProto(loop=self.loop), sock=sock)
except TypeError as ex:
# asyncio in 3.5.0 doesn't have the 'sock' argument

This comment has been minimized.

@1st1

1st1 Oct 15, 2018

Member

Better to simply skip this test under 3.5.

@pax0r pax0r force-pushed the pax0r:dns-lookup-error branch from 093bcf2 to 86bb574 Oct 16, 2018
@1st1 1st1 merged commit 64b7911 into MagicStack:master Oct 18, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@1st1
Copy link
Member

1st1 commented Oct 18, 2018

Thank you!

@1st1
Copy link
Member

1st1 commented Oct 31, 2018

Released in uvloop v0.11.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.