Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFatal error on transport TCPTransport leads to AttributeError: 'NoneType' object has no attribute 'cancel' #255
Comments
|
Thanks for the bug report! @fantix what do you think about this? |
|
@mjpieters Thanks for the verification! Your conclusion is correct, in the case when the peer closes the writing end of the underlying TCP connection without sending an SSL shutdown message, Your fix is a good one, I'll write a test to cover the case. |
|
@fantix do you need anything else from me to create a test for this still? |
|
@mjpieters oh sorry I was distracted, yeah it'll be really nice if you can also provide a test. I'll only have time after next week. Appreciate you asked |
* Fixes MagicStack#255
* Fixes MagicStack#255 * Also make handles more robust
* Fixes MagicStack#255 * Also make handles more robust
* Fixes MagicStack#255 * Also make handles more robust
* Fixes MagicStack#255 * Also make handles more robust
|
I've just published https://github.com/MagicStack/uvloop/releases/tag/v0.14.0rc1. Please test. The final release will be published some time next week if RC1 is OK. |
PYTHONASYNCIODEBUGin env?: YesI'm seeing the following error appear:
This looks to be the same issue as aio-libs/aiohttp#3535 and python/cpython#13548, but with an added twist that uvloop's SSLProtocol implementation has a bug of its own. The attribute error is thrown because
_shutdown_timeout_handlehas not been set, and it is not set because_start_shutdownhas not been called.After verification that the issue is still present on master, I worked around this issue by testing for the handle in
_on_shutdown_complete