★ wanayoo — archive 1999 https://github.com/JavaScriptor/js-sql-parser/pull/10Nouvelle recherche | Portail wanayoo
Skip to content

/ js-sql-parser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement INSERT and UPDATE parsing #10

Open
wants to merge 3 commits into
base: master
from
Open

Implement INSERT and UPDATE parsing #10

wants to merge 3 commits into from

Conversation

@gpittarelli
Copy link

gpittarelli commented Apr 10, 2018 •
edited

Implements parsing for INSERT and UPDATE queries, per the MySQL 5.7 grammar. Includes pretty printing + test cases.

(Note: for my own purposes, I've published this branch under @gpittarelli/js-sql-parser)
@gpittarelli gpittarelli force-pushed the gpittarelli:master branch from 07557f3 to 344c350 Apr 10, 2018
@gpittarelli
Implement UPDATE
Verified
This commit was signed with a verified signature.
gpittarelli George Pittarelli
GPG key ID: F74C95397D7BE36D Learn about signing commits
c4b1c55
@gpittarelli gpittarelli force-pushed the gpittarelli:master branch from 344c350 to bec7988 Apr 10, 2018
@gpittarelli
Implement INSERT
Verified
This commit was signed with a verified signature.
gpittarelli George Pittarelli
GPG key ID: F74C95397D7BE36D Learn about signing commits
Loading status checks…
84f4402
@gpittarelli gpittarelli force-pushed the gpittarelli:master branch from bec7988 to 84f4402 Apr 10, 2018
@albin3 albin3 added the enhancement label Apr 11, 2018
@albin3
Copy link
Member

albin3 commented Apr 11, 2018

Great, i'm a little busy these days, i will review it later.
@gpittarelli
Handle VALUES in ON DUPLICATE KEY UPDATE queries
Verified
This commit was signed with a verified signature.
gpittarelli George Pittarelli
GPG key ID: F74C95397D7BE36D Learn about signing commits
Loading status checks…
8bc20b0
@albin3
Copy link
Member

albin3 commented Jul 15, 2018

hi, @gpittarelli .

I reviewed the insert part in this pr and there are something need to change / some questions need to confirm:

  1. following https://dev.mysql.com/doc/refman/5.7/en/insert.html , simple_table_factor grammar may be should be replaced by identifier.
  2. more test cases are needed for for the new code.
  3. suggestion: format the code more similar with document in https://dev.mysql.com/doc/refman/5.7/en/insert.html , such as there are three insert grammars in document, we also write it into three lines. So, it's more readable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@gpittarelli @albin3
You can’t perform that action at this time.