Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCMake: find_packages #139
CMake: find_packages #139
Comments
|
Probably. Indeed, it is also the right time to do so as we just updated everything to modern cmake. xtl 0.4.0 Regarding pybind11, we have been conservative about updating it as there has been some breakages between 2.0 and 2.1... We should probably test the latest versions as they come out. |
|
Regarding Nevertheless, 2.2.2 is only 4 days old, so there might be some time until it gets a version assigned. |
|
@ax3l Just a question about the indirect dependency, if C depends on B that depends on A, don't we have to do In the case of the Asked differently, is it possible with cmake to handle transitive dependencies without |
With modern CMake one can finally forget about this and only account for the dependencies one faces directly. This was always especially troublesome for header-only libs, since we as developers had to explain users "you only depend on B but... you don't know that... but B depends on A so you depend on B and A at compile time".
Yes, that's exactly it. Just expose these indirect dependencies properly as |
|
side note: but in the case of But |
|
@ax3l thank you for the clarification! I agree with you, |
|
Well, I was just thinking loud as well to verify I got the dependencies right ;) |
Hi,
we should improve the way we are currently looking for xtensor-python dependencies:
I think we could add the following:
find_packagecallnumpyis a direct dependency, it's not documented; which version range is known to work?xtlis not only an indirect dependency ofxtensor(which would mean we can remove thefind_packageand take automatically addedPUBLICdependency of thextensordependency) but also a direct dependency used inxtensor-pythoncode: expose it in the readme with its version range as well