★ wanayoo — archive 1999 https://github.com/pythongssapi/python-gssapi/issues/130Nouvelle recherche | Portail wanayoo
Skip to content

/ python-gssapi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion's dependencies in tests #130

Closed
stanislavlevin opened this issue Nov 20, 2017 · 3 comments
Closed

Assertion's dependencies in tests #130

stanislavlevin opened this issue Nov 20, 2017 · 3 comments
Assignees
@DirectXMan12

Comments

@stanislavlevin
Copy link
Contributor

@stanislavlevin stanislavlevin commented Nov 20, 2017 •
edited

Hello.

python-gssapi tests are using shouldbe python module(based on forbiddenfruit), which are look like abandoned and are not supported python 3.5 and above. Moreover, most of Linux distr are not packing these modules, so there is no possibility to run tests of python-gssapi during build time.

I've prepared a patch to change assertion code to nose(based on unittest).
An attached patch is for v1.2.2 + fix bd61844
All tests have been passed.

Thank you.

0001-Change-assertion-s-Python-dependencies-from-shouldbe.patch.txt

21/11/2017: patch was updated due to i586 build error(fixed)
@frozencemetery
Copy link
Member

@frozencemetery frozencemetery commented Nov 20, 2017

@DirectXMan12 can you confirm or deny that you abandoned your own python module? :P

More seriously though, as the guy who does the packaging for three of them, being able to run tests at build time in distros would be nice.
@stanislavlevin
Copy link
Contributor Author

@stanislavlevin stanislavlevin commented Nov 21, 2017 •
edited

My Linux distro is AltLinux(rpm-based).
I guess tests are very important, but unfortunately there was no tests running before.
@DirectXMan12
Copy link
Member

@DirectXMan12 DirectXMan12 commented Nov 27, 2017

@DirectXMan12 can you confirm or deny that you abandoned your own python module? :P

I can neither confirm nor deny that. Please see [redacted] for [redacted] [redacted] :-P

On a more serious note, I've just tested locally on Python 3.5, and should_be works fine in Python 3.5. That being said, I wouldn't mind an extension to should_be or something of the sort to allow the use of an expect(xyz).to_be(abc) instead of using forbiddenfruit. It shouldn't be too hard. I don't have a lot of time right now, but I'd certainly accept a patch.

In any case, we accept patches in the form of GitHub pull requests, so please submit any future changes in that form.
@stanislavlevin stanislavlevin mentioned this issue Jul 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DirectXMan12 DirectXMan12

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@DirectXMan12 @frozencemetery @stanislavlevin
You can’t perform that action at this time.