★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/ef8c1deda6Nouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files

doc,meta: update PR approving info

Refs: #22255

PR-URL: #24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  • Loading branch information...
vsemozhetbyt authored and codebytere committed Nov 21, 2018
1 parent 0b81054 commit ef8c1deda6b22b76a520b93ade618a7a4b290f7c
Showing with 2 additions and 1 deletion.
  1. +2 −1 doc/guides/contributing/pull-requests.md
@@ -416,7 +416,8 @@ unhelpful is likely safe to ignore.
### Step 10: Landing

In order to land, a Pull Request needs to be reviewed and [approved][] by
at least one Node.js Collaborator and pass a
at least two Node.js Collaborators (one Collaborator approval is enough if the
pull request has been open for more than 7 days) and pass a
[CI (Continuous Integration) test run][]. After that, as long as there are no
objections from other contributors, the Pull Request can be merged. If you find
your Pull Request waiting longer than you expect, see the

0 comments on commit ef8c1de

Please sign in to comment.
You can’t perform that action at this time.