test: add useful info to error msg and refactor

Add useful info about process.domain to error meesages in the uncaughtException event listener and the beforeExit event listener. Refactor code such as using template literals, and also make sure uncaughtException listner is detached after firing once to avoid endless loop in case of exception throw in the beforeExit event listner. PR-URL: #18541 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Feb 21, 2018 · e9c9200aba782f28cd70ec566d85c4bd9a289280 · e9c9200
1 parent 35ce3a8
commit e9c9200aba782f28cd70ec566d85c4bd9a289280
Showing with 7 additions and 4 deletions.

+7 −4 test/parallel/test-domain-stack-empty-in-process-uncaughtexception.js
diff --git a/test/parallel/test-domain-stack-empty-in-process-uncaughtexception.js b/test/parallel/test-domain-stack-empty-in-process-uncaughtexception.js
@@ -6,15 +6,18 @@ const assert = require('assert');
 
 const d = domain.create();
 
-process.on('uncaughtException', common.mustCall(function onUncaught() {
+process.once('uncaughtException', common.mustCall(function onUncaught() {
   assert.strictEqual(
     process.domain, null,
-    'domains stack should be empty in uncaughtException handler');
+    'Domains stack should be empty in uncaughtException handler ' +
+    `but the value of process.domain is ${JSON.stringify(process.domain)}`);
 }));
 
 process.on('beforeExit', common.mustCall(function onBeforeExit() {
-  assert.strictEqual(process.domain, null,
-                     'domains stack should be empty in beforeExit handler');
+  assert.strictEqual(
+    process.domain, null,
+    'Domains stack should be empty in beforeExit handler ' +
+    `but the value of process.domain is ${JSON.stringify(process.domain)}`);
 }));
 
 d.run(function() {