tools: enable no-useless-catch lint rule

This commit enables ESLint's no-useless-catch rule. PR-URL: #25236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Dec 27, 2018 · e6b5232381836b38e88feb0a5bb6a68b739eb2fc · e6b5232
1 parent f944a75
commit e6b5232381836b38e88feb0a5bb6a68b739eb2fc
Unified Split

Showing with 2 additions and 1 deletion.

+1 −0 .eslintrc.js

+1 −1 lib/vm.js
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -234,6 +234,7 @@ module.exports = {
      variables: false,
    }],
    'no-useless-call': 'error',
+  
+    'no-useless-catch': 'error',
    'no-useless-concat': 'error',
    'no-useless-constructor': 'error',
    'no-useless-escape': 'error',

diff --git a/lib/vm.js b/lib/vm.js
@@ -80,7 +80,7 @@ class Script extends ContextifyScript {
    // Calling `ReThrow()` on a native TryCatch does not generate a new
    // abort-on-uncaught-exception check. A dummy try/catch in JS land
    // protects against that.
-  
-    try {
+  
+    try { // eslint-disable-line no-useless-catch
      super(code,
            filename,
            lineOffset,