deps: V8: fix BUILDING_V8_SHARED issues

Backport-PR-URL: #28955 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · May 26, 2019 · c9f8d28f7190cbdb615238e2e9b54880fea2a661 · c9f8d28
1 parent f24caef
commit c9f8d28f7190cbdb615238e2e9b54880fea2a661
Unified Split

Showing with 7 additions and 1 deletion.

+1 −1 common.gypi

+1 −0 deps/v8/src/init/setup-isolate-deserialize.cc

+4 −0 deps/v8/src/objects/ordered-hash-table.cc

+1 −0 deps/v8/src/snapshot/snapshot.h
diff --git a/common.gypi b/common.gypi
@@ -38,7 +38,7 @@
    # Reset this number to 0 on major V8 upgrades.
    # Increment by one for each non-official patch applied to deps/v8.
-  
-    'v8_embedder_string': '-node.8',
+  
+    'v8_embedder_string': '-node.9',
    ##### V8 defaults for Node.js #####

diff --git a/deps/v8/src/init/setup-isolate-deserialize.cc b/deps/v8/src/init/setup-isolate-deserialize.cc
@@ -7,6 +7,7 @@
 #include "src/base/logging.h"
 #include "src/execution/isolate.h"
 #include "src/interpreter/interpreter.h"
+  
+#include "src/objects/objects-inl.h"
 #include "src/utils/ostreams.h"
 namespace v8 {

diff --git a/deps/v8/src/objects/ordered-hash-table.cc b/deps/v8/src/objects/ordered-hash-table.cc
@@ -930,6 +930,7 @@ OrderedHashTableHandler<SmallOrderedNameDictionary,
                        OrderedNameDictionary>::Allocate(Isolate* isolate,
                                                         int capacity);
+  
+#if !defined(V8_OS_WIN)
 template <class SmallTable, class LargeTable>
 bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
    Handle<HeapObject> table, Handle<Object> key) {
@@ -942,7 +943,9 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
  // down to a smaller hash table.
  return LargeTable::Delete(Handle<LargeTable>::cast(table), key);
 }
+  
+#endif
+  
+#if !defined(V8_OS_WIN)
 template <class SmallTable, class LargeTable>
 bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
    Isolate* isolate, Handle<HeapObject> table, Handle<Object> key) {
@@ -953,6 +956,7 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
  DCHECK(LargeTable::Is(table));
  return LargeTable::HasKey(isolate, LargeTable::cast(*table), *key);
 }
+  
+#endif
 template bool
 OrderedHashTableHandler<SmallOrderedHashSet, OrderedHashSet>::HasKey(

diff --git a/deps/v8/src/snapshot/snapshot.h b/deps/v8/src/snapshot/snapshot.h
@@ -8,6 +8,7 @@
 #include "src/snapshot/partial-serializer.h"
 #include "src/snapshot/startup-serializer.h"
+  
+#include "src/objects/objects-inl.h"
 #include "src/utils/utils.h"
 namespace v8 {