process: register the inspector async hooks in bootstrap/node.js

So it's easier to tell the side effects of this setup. PR-URL: #25443 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs · Jan 10, 2019 · c718592147cd3a60b5cc74f186ae14ed1b73a01f · c718592
1 parent cb73fed
commit c718592147cd3a60b5cc74f186ae14ed1b73a01f
Unified Split

Showing with 9 additions and 10 deletions.

+5 −1 lib/internal/bootstrap/node.js

+4 −9 lib/internal/inspector_async_hook.js
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -151,7 +151,11 @@ function startup() {
  }
  if (config.hasInspector) {
-  
-    NativeModule.require('internal/inspector_async_hook').setup();
+  
+    const {
+  
+      enable,
+  
+      disable
+  
+    } = NativeModule.require('internal/inspector_async_hook');
+  
+    internalBinding('inspector').registerAsyncHook(enable, disable);
  }
  // If the process is spawned with env NODE_CHANNEL_FD, it's probably

diff --git a/lib/internal/inspector_async_hook.js b/lib/internal/inspector_async_hook.js
@@ -1,16 +1,10 @@
 'use strict';
-  
-const inspector = internalBinding('inspector');
-  
-
-  
-if (!inspector || !inspector.asyncTaskScheduled) {
-  
-  exports.setup = function() {};
-  
-  return;
-  
-}
-  
-
 let hook;
 let config;
 function lazyHookCreation() {
+  
+  const inspector = internalBinding('inspector');
  const { createHook } = require('async_hooks');
  config = internalBinding('config');
@@ -72,6 +66,7 @@ function disable() {
  hook.disable();
 }
-  
-exports.setup = function() {
-  
-  inspector.registerAsyncHook(enable, disable);
+  
+module.exports = {
+  
+  enable,
+  
+  disable
 };