net: remove unreachable check in internalConnect

Checked all call-sites to ensure that this code is truly unreachable. addressType is always checked before internalConnect is even called. PR-URL: #24158 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Nov 15, 2018 · c53117e7ea26fafd763af82ec2e1547a99773f7a · c53117e
1 parent c07cce3
commit c53117e7ea26fafd763af82ec2e1547a99773f7a
Showing with 1 addition and 4 deletions.

+1 −4 lib/net.js
diff --git a/lib/net.js b/lib/net.js
@@ -830,12 +830,9 @@ function internalConnect(
     if (addressType === 4) {
       localAddress = localAddress || '0.0.0.0';
       err = self._handle.bind(localAddress, localPort);
-    } else if (addressType === 6) {
+    } else { // addressType === 6
       localAddress = localAddress || '::';
       err = self._handle.bind6(localAddress, localPort);
-    } else {
-      self.destroy(new ERR_INVALID_ADDRESS_FAMILY(addressType));
-      return;
     }
     debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
           localAddress, localPort, addressType);