src: use SealHandleScope for inspector tasks

This addresses a TODO comment that can be resolved, now that we have V8 7.4. PR-URL: #27116 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
nodejs · Apr 10, 2019 · c1e03eda07758a08e9469f5aa94038902bf9aacb · c1e03ed
1 parent f1ab837
commit c1e03eda07758a08e9469f5aa94038902bf9aacb
Showing with 1 addition and 7 deletions.

+1 −7 src/inspector/main_thread_interface.cc
diff --git a/src/inspector/main_thread_interface.cc b/src/inspector/main_thread_interface.cc
@@ -269,13 +269,7 @@ void MainThreadInterface::DispatchMessages() {
       std::swap(dispatching_message_queue_.front(), task);
       dispatching_message_queue_.pop_front();
 
-      // TODO(addaleax): The V8 inspector code currently sometimes allocates
-      // handles that leak to the outside scope, rendering a HandleScope here
-      // necessary. This handle scope can be removed/turned into a
-      // SealHandleScope once/if
-      // https://chromium-review.googlesource.com/c/v8/v8/+/1484304 makes it
-      // into our copy of V8, maybe guarded with #ifdef DEBUG if we want.
-      v8::HandleScope handle_scope(isolate_);
+      v8::SealHandleScope seal_handle_scope(isolate_);
       task->Call(this);
     }
   } while (had_messages);