fs: fix fsPromises.lchmod error on non-Mac

On non-macOS, fsPromises.lchmod throws AssertionError. Expected behavior is `Error [ERR_METHOD_NOT_IMPLEMENTED]`. `ERR_METHOD_NOT_IMPLEMENTED()` requires argument, but it wasn't set. Fixes `ERR_METHOD_NOT_IMPLEMENTED()` to `ERR_METHOD_NOT_IMPLEMENTED('lchmod()')`. PR-URL: #21435 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
nodejs · Jun 21, 2018 · b758006c23803bb70caef47aae6cc76c19bf3b85 · b758006
1 parent 51db88b
commit b758006c23803bb70caef47aae6cc76c19bf3b85
Unified Split

Showing with 14 additions and 3 deletions.

+1 −1 lib/internal/fs/promises.js

+13 −2 test/parallel/test-fs-promises.js
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -371,7 +371,7 @@ async function chmod(path, mode) {
 async function lchmod(path, mode) {
  if (O_SYMLINK === undefined)
-  
-    throw new ERR_METHOD_NOT_IMPLEMENTED();
+  
+    throw new ERR_METHOD_NOT_IMPLEMENTED('lchmod()');
  const fd = await open(path, O_WRONLY | O_SYMLINK);
  return fchmod(fd, mode).finally(fd.close.bind(fd));

diff --git a/test/parallel/test-fs-promises.js b/test/parallel/test-fs-promises.js
@@ -140,15 +140,26 @@ function verifyStatObject(stat) {
                         (await realpath(newLink)).toLowerCase());
      assert.strictEqual(newPath.toLowerCase(),
                         (await readlink(newLink)).toLowerCase());
+  
+
+  
+      const newMode = 0o666;
      if (common.isOSX) {
        // lchmod is only available on macOS
-  
-        const newMode = 0o666;
        await lchmod(newLink, newMode);
        stats = await lstat(newLink);
        assert.strictEqual(stats.mode & 0o777, newMode);
+  
+      } else {
+  
+        await Promise.all([
+  
+          assert.rejects(
+  
+            lchmod(newLink, newMode),
+  
+            common.expectsError({
+  
+              code: 'ERR_METHOD_NOT_IMPLEMENTED',
+  
+              type: Error,
+  
+              message: 'The lchmod() method is not implemented'
+  
+            })
+  
+          )
+  
+        ]);
      }
-  
-
      await unlink(newLink);
    }