lib: simplify own keys retrieval

This replacement can save us a function call, two array spreadings, and an array concatenation. PR-URL: #24582 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/ownKeys#Description Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs · Nov 28, 2018 · b2c243ff8be562ab6dec3b0d05e783040aa34708 · b2c243f
1 parent 35a7646
commit b2c243ff8be562ab6dec3b0d05e783040aa34708
Showing with 1 addition and 3 deletions.

+1 −3 lib/internal/safe_globals.js
diff --git a/lib/internal/safe_globals.js b/lib/internal/safe_globals.js
@@ -1,9 +1,7 @@
 'use strict';
 
 const copyProps = (unsafe, safe) => {
-  for (const key of [...Object.getOwnPropertyNames(unsafe),
-                     ...Object.getOwnPropertySymbols(unsafe)
-  ]) {
+  for (const key of Reflect.ownKeys(unsafe)) {
     if (!Object.getOwnPropertyDescriptor(safe, key)) {
       Object.defineProperty(
         safe,