console: console.timeLog() using the default label

PR-URL: #24286 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Nov 10, 2018 · a2c13fac9468ca56e98e00a7acc34d8dcd9b166b · a2c13fa
1 parent 7601cdf
commit a2c13fac9468ca56e98e00a7acc34d8dcd9b166b
Unified Split

Showing with 17 additions and 2 deletions.

+2 −2 lib/console.js

+15 −0 test/parallel/test-console.js
diff --git a/lib/console.js b/lib/console.js
@@ -253,15 +253,15 @@ Console.prototype.timeEnd = function timeEnd(label = 'default') {
  }
 };
-  
-Console.prototype.timeLog = function timeLog(label, ...data) {
+  
+Console.prototype.timeLog = function timeLog(label = 'default', ...data) {
  // Coerces everything other than Symbol to a string
  label = `${label}`;
  timeLogImpl(this, 'timeLog', label, data);
  trace(kTraceInstant, kTraceConsoleCategory, `time::${label}`, 0);
 };
 // Returns true if label was not found
-  
-function timeLogImpl(self, name, label = 'default', data) {
+  
+function timeLogImpl(self, name, label, data) {
  const time = self._times.get(label);
  if (!time) {
    process.emitWarning(`No such label '${label}' for console.${name}()`);

diff --git a/test/parallel/test-console.js b/test/parallel/test-console.js
@@ -45,6 +45,10 @@ common.expectWarning(
    ['Count for \'noLabel\' does not exist', common.noWarnCode],
    ['No such label \'noLabel\' for console.timeLog()', common.noWarnCode],
    ['No such label \'noLabel\' for console.timeEnd()', common.noWarnCode],
+  
+    ['Count for \'default\' does not exist', common.noWarnCode],
+  
+    ['No such label \'default\' for console.timeLog()', common.noWarnCode],
+  
+    ['No such label \'default\' for console.timeEnd()', common.noWarnCode],
+  
+    ['Label \'default\' already exists for console.time()', common.noWarnCode],
    ['Label \'test\' already exists for console.time()', common.noWarnCode]
  ]
 );
@@ -56,6 +60,17 @@ console.timeEnd('noLabel');
 console.time('label');
 console.timeEnd('label');
+  
+// Test using the default label
+  
+// on console.time(), console.countReset(), console.timeLog(), console.timeEnd()
+  
+console.countReset();
+  
+console.timeLog();
+  
+console.timeEnd();
+  
+
+  
+console.time();
+  
+console.time();
+  
+console.timeLog();
+  
+console.timeEnd();
+  
+
 // Check that the `Error` is a `TypeError` but do not check the message as it
 // will be different in different JavaScript engines.
 assert.throws(() => console.time(Symbol('test')),