console: don't use ANSI escape codes when TERM=dumb

PR-URL: #26261 Fixes: #26187 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
nodejs · Feb 22, 2019 · 99523758dc5d076b8f34259961291d7db2e6d497 · 9952375
1 parent 5f032a7
commit 99523758dc5d076b8f34259961291d7db2e6d497
Unified Split

Showing with 14 additions and 1 deletion.

+1 −1 lib/internal/console/constructor.js

+9 −0 test/pseudo-tty/console-dumb-tty.js

+4 −0 test/pseudo-tty/console-dumb-tty.out
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -346,7 +346,7 @@ const consoleMethods = {
  clear() {
    // It only makes sense to clear if _stdout is a TTY.
    // Otherwise, do nothing.
-  
-    if (this._stdout.isTTY) {
+  
+    if (this._stdout.isTTY && process.env.TERM !== 'dumb') {
      // The require is here intentionally to avoid readline being
      // required too early when console is first loaded.
      const { cursorTo, clearScreenDown } = require('readline');

diff --git a/test/pseudo-tty/console-dumb-tty.js b/test/pseudo-tty/console-dumb-tty.js
@@ -0,0 +1,9 @@
+  
+'use strict';
+  
+require('../common');
+  
+
+  
+process.env.TERM = 'dumb';
+  
+
+  
+console.log({ foo: 'bar' });
+  
+console.dir({ foo: 'bar' });
+  
+console.log('%s q', 'string');
+  
+console.log('%o with object format param', { foo: 'bar' });
diff --git a/test/pseudo-tty/console-dumb-tty.out b/test/pseudo-tty/console-dumb-tty.out
@@ -0,0 +1,4 @@
+  
+{ foo: 'bar' }
+  
+{ foo: 'bar' }
+  
+string q
+  
+{ foo: 'bar' } with object format param