★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/989c2aaf83Nouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files
test: fix flaky test-vm-timeout-escape-nexttick
Increase the VM timeout. If it is too small, the VM does not exit before
the code has a chance to create the problematic condition that causes
the timeout to be ignored.

Fixes: #24120

PR-URL: #24251
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
Trott authored and BridgeAR committed Nov 13, 2018
1 parent 7bcc4cc commit 989c2aaf830c974dc87a0f080834ff08bfd831ab
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/known_issues/test-vm-timeout-escape-nexttick.js
@@ -35,7 +35,7 @@ assert.throws(() => {
nextTick,
loop
},
{ timeout: common.platformTimeout(5) }
{ timeout: common.platformTimeout(10) }
);
}, {
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT'

0 comments on commit 989c2aa

Please sign in to comment.