★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/8f7e37337fNouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files

lib: remove unused filterInternalStackFrames param

Actually we don't refer the `error` directly in
`filterInternalStackFrames`, so just remove it anyway.

PR-URL: #22267
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Maledong authored and rvagg committed Aug 11, 2018
1 parent 9d89b3c commit 8f7e37337f016d5e7c48f6d4659b742c11a6ac2c
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/repl.js
@@ -494,7 +494,7 @@ function REPLServer(prompt,
self.writer.options = Object.assign({}, writer.options, { colors: true });
}

function filterInternalStackFrames(error, structuredStack) {
function filterInternalStackFrames(structuredStack) {
// Search from the bottom of the call stack to
// find the first frame with a null function name
if (typeof structuredStack !== 'object')
@@ -509,7 +509,7 @@ function REPLServer(prompt,

function prepareStackTrace(fn) {
return (error, stackFrames) => {
const frames = filterInternalStackFrames(error, stackFrames);
const frames = filterInternalStackFrames(stackFrames);
if (fn) {
return fn(error, frames);
}

0 comments on commit 8f7e373

Please sign in to comment.
You can’t perform that action at this time.