test: pin regression test for #8074 to TLS 1.2

This test has a dependency on the order in which the TCP connection is made, and TLS server handshake completes. It assumes those server side events occur before the client side write callback, which is not guaranteed by the TLS API. It usually passes with TLS1.3, but TLS1.3 didn't exist at the time the bug existed. Pin the test to TLS1.2, since the test shouldn't be changed in a way that doesn't trigger a segfault in 7.7.3: - #13184 (comment) PR-URL: #25508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jan 15, 2019 · 7e9f5ea29594f52b82b1e1769058da2d775f5772 · 7e9f5ea
1 parent 2b1f881
commit 7e9f5ea29594f52b82b1e1769058da2d775f5772
Unified Split

Showing with 13 additions and 0 deletions.

+13 −0 test/parallel/test-tls-socket-close.js
diff --git a/test/parallel/test-tls-socket-close.js b/test/parallel/test-tls-socket-close.js
@@ -8,6 +8,19 @@ const tls = require('tls');
 const net = require('net');
 const fixtures = require('../common/fixtures');
+  
+// Regression test for https://github.com/nodejs/node/issues/8074
+  
+//
+  
+// This test has a dependency on the order in which the TCP connection is made,
+  
+// and TLS server handshake completes. It assumes those server side events occur
+  
+// before the client side write callback, which is not guaranteed by the TLS
+  
+// API. It usally passes with TLS1.3, but TLS1.3 didn't exist at the time the
+  
+// bug existed.
+  
+//
+  
+// Pin the test to TLS1.2, since the test shouldn't be changed in a way that
+  
+// doesn't trigger a segfault in Node.js 7.7.3:
+  
+//   https://github.com/nodejs/node/issues/13184#issuecomment-303700377
+  
+tls.DEFAULT_MAX_VERSION = 'TLSv1.2';
+  
+
 const key = fixtures.readKey('agent2-key.pem');
 const cert = fixtures.readKey('agent2-cert.pem');