lib: improved conditional check in zlib

PR-URL: #24190 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Nov 6, 2018 · 5c2c5b9094f633f52ba914598ccde184d034f1d3 · 5c2c5b9
1 parent 6cad1b6
commit 5c2c5b9094f633f52ba914598ccde184d034f1d3
Unified Split

Showing with 6 additions and 8 deletions.

+6 −8 lib/zlib.js
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -347,8 +347,7 @@ Object.defineProperty(Zlib.prototype, 'bytesRead', {
 // `params()` function should not happen while a write is currently in progress
 // on the threadpool.
 function paramsAfterFlushCallback(level, strategy, callback) {
-  
-  if (!this._handle)
-  
-    assert(false, 'zlib binding closed');
+  
+  assert(this._handle, 'zlib binding closed');
  this._handle.params(level, strategy);
  if (!this._hadError) {
    this._level = level;
@@ -504,8 +503,8 @@ function processChunkSync(self, chunk, flushFlag) {
      else
        buffers.push(out);
      nread += out.byteLength;
-  
-    } else if (have < 0) {
-  
-      assert(false, 'have should not go down');
+  
+    } else {
+  
+      assert(have === 0, 'have should not go down');
    }
    // exhausted the output buffer, or used all the input create a new one.
@@ -542,8 +541,7 @@ function processChunkSync(self, chunk, flushFlag) {
 function processChunk(self, chunk, flushFlag, cb) {
  var handle = self._handle;
-  
-  if (!handle)
-  
-    assert(false, 'zlib binding closed');
+  
+  assert(handle, 'zlib binding closed');
  handle.buffer = chunk;
  handle.cb = cb;
@@ -590,8 +588,8 @@ function processCallback() {
    var out = self._outBuffer.slice(self._outOffset, self._outOffset + have);
    self._outOffset += have;
    self.push(out);
-  
-  } else if (have < 0) {
-  
-    assert(false, 'have should not go down');
+  
+  } else {
+  
+    assert(have === 0, 'have should not go down');
  }
  if (self.destroyed) {