★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/4b0d2de5f4Nouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files
zlib: remove unused parameters
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter
function only has two parameters, so `lower` and `upper` don't need to
be passed for validation.

PR-URL: #22115
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
MaleDong authored and rvagg committed Aug 15, 2018
1 parent 3f729aa commit 4b0d2de5f470b099f6c87c745074feb07f849e1c
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/zlib.js
@@ -198,12 +198,12 @@ function checkFiniteNumber(number, name) {
throw err;
}

// 1. Returns def for undefined and NaN
// 1. Returns def for number when it's undefined or NaN
// 2. Returns number for finite numbers >= lower and <= upper
// 3. Throws ERR_INVALID_ARG_TYPE for non-numbers
// 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower
function checkRangesOrGetDefault(number, name, lower, upper, def) {
if (!checkFiniteNumber(number, name, lower, upper)) {
if (!checkFiniteNumber(number, name)) {
return def;
}
if (number < lower || number > upper) {

0 comments on commit 4b0d2de

Please sign in to comment.