test: verify order of error in h2 server stream

Currently the order of error / closing of an h2 stream is consistent in 10.x, 11.x, and master. There appears to be an unexpected behavior difference in 8.x. This test will be used to bisect the commit that will fix this behavior change and ensure there are no future regressions. PR-URL: #24685 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Dec 11, 2018 · 394cb42962f542127ab3e8309d3143319ab44226 · 394cb42
1 parent 62fb5db
commit 394cb42962f542127ab3e8309d3143319ab44226
Showing with 43 additions and 0 deletions.

+43 −0 test/parallel/test-http2-error-order.js
diff --git a/test/parallel/test-http2-error-order.js b/test/parallel/test-http2-error-order.js
@@ -0,0 +1,43 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const { createServer, connect } = require('http2');
+
+const messages = [];
+const expected = [
+  'Stream:created',
+  'Stream:error',
+  'Stream:close',
+  'Request:error'
+];
+
+const server = createServer();
+
+server.on('stream', (stream) => {
+  messages.push('Stream:created');
+  stream
+    .on('close', () => messages.push('Stream:close'))
+    .on('error', (err) => messages.push('Stream:error'))
+    .respondWithFile('dont exist');
+});
+
+server.listen(0);
+
+const client = connect(`http://localhost:${server.address().port}`);
+const req = client.request();
+
+req.on('response', common.mustNotCall());
+
+req.on('error', () => {
+  messages.push('Request:error');
+  client.close();
+});
+
+client.on('close', common.mustCall(() => {
+  assert.deepStrictEqual(messages, expected);
+  server.close();
+}));