build, tools, win: add .S files support to GYP

Makes GYP properly handle .S files. Fixes: nodejs/node-v8#89 PR-URL: #24553 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · Nov 29, 2018 · 383d8092b1faf8380966ae35cf6e6ae9399f5fbc · 383d809
1 parent 899e7c3
commit 383d8092b1faf8380966ae35cf6e6ae9399f5fbc
Showing with 2 additions and 1 deletion.

+2 −1 tools/gyp/pylib/gyp/generator/msvs.py
diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py
@@ -2156,6 +2156,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
       A pair of (group this file should be part of, the label of element)
   """
   _, ext = os.path.splitext(source)
+  ext = ext.lower()
   if ext in extension_to_rule_name:
     group = 'rule'
     element = extension_to_rule_name[ext]
@@ -2168,7 +2169,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
   elif ext == '.rc':
     group = 'resource'
     element = 'ResourceCompile'
-  elif ext == '.asm':
+  elif ext in ['.s', '.asm']:
     group = 'masm'
     element = 'MASM'
   elif ext == '.idl':