★ wanayoo — archive 1999 https://github.com/nodejs/node/commit/2734c20bd9Nouvelle recherche | Portail wanayoo
Skip to content
Permalink
Browse files

doc: simplify first-time contributors section of Collaborator Guide

PR-URL: #24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
  • Loading branch information...
Trott authored and codebytere committed Nov 16, 2018
1 parent fa52ba6 commit 2734c20bd9fb327faadff1f582447d71205de672
Showing with 6 additions and 8 deletions.
  1. +6 −8 COLLABORATOR_GUIDE.md
@@ -50,16 +50,14 @@ request. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker).

### Welcoming First-Time Contributors

Courtesy should always be shown to individuals submitting issues and pull
requests to the Node.js project. Be welcoming to first-time contributors,
identified by the GitHub ![First-time contributor](./doc/first_timer_badge.png)
badge.
Always show courtesy to individuals submitting issues and pull requests. Be
welcoming to first-time contributors, identified by the GitHub
![First-time contributor](./doc/first_timer_badge.png) badge.

For first-time contributors, check if the commit author is the same as the
pull request author, and ask if they have configured their git
For first-time contributors, check if the commit author is the same as the pull
request author. This way, once their pull request lands, GitHub will show them
as a _Contributor_. Ask if they have configured their git
[username][git-username] and [email][git-email] to their liking.
This is to make sure they would be promoted to "contributor" once their
pull request lands.

### Closing Issues and Pull Requests

0 comments on commit 2734c20

Please sign in to comment.
You can’t perform that action at this time.