tls: destroy TLS socket if StreamWrap is destroyed

Previously, there was no mechanism in place that would have destroyed the TLS socket once the underlying socket had been closed. PR-URL: #24290 Refs: #24288 Refs: #24075 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
nodejs · Nov 10, 2018 · 0f6a9524f82ca435ae5c53dfc580b7b37dbf9913 · 0f6a952
1 parent 0c73221
commit 0f6a9524f82ca435ae5c53dfc580b7b37dbf9913
Unified Split

Showing with 4 additions and 2 deletions.

+4 −2 lib/_tls_wrap.js
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -310,10 +310,12 @@ function TLSSocket(socket, opts) {
  // Wrap plain JS Stream into StreamWrap
  var wrap;
-  
-  if ((socket instanceof net.Socket && socket._handle) || !socket)
+  
+  if ((socket instanceof net.Socket && socket._handle) || !socket) {
    wrap = socket;
-  
-  else
+  
+  } else {
    wrap = new StreamWrap(socket);
+  
+    wrap.once('close', () => this.destroy());
+  
+  }
  // Just a documented property to make secure sockets
  // distinguishable from regular ones.