★ wanayoo — archive 1999 https://github.com/nficano/python-lambda/issues/126Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision of pip internals making the pip install stop after one package #126

Closed
kmbenitez opened this issue Sep 12, 2018 · 8 comments
Closed

Comments

@kmbenitez
Copy link

@kmbenitez kmbenitez commented Sep 12, 2018

On my most recent invocations of lambda build I'm only getting the first package listed in my requirements.txt installed to the build. The output says that the rest are being processed, but the install is returning an error.

Given that Pip is actively trying to discourage use of itself as a package, I think it's time to begin using subprocess.

@gmyers-amfam
Copy link
Contributor

@gmyers-amfam gmyers-amfam commented Sep 12, 2018

What version of python-lambda are you using? And what version of pip? Can you post the contents of your requirements.txt file?

@winsome
Copy link

@winsome winsome commented Sep 12, 2018 •

@gmyers-amfam I'm seeing the same issue with python-lambda 3.2.4, pip 18.0, and the following requirements.txt

futures==3.2.0
jmespath==0.9.0

futures is installed into the zip whereas jmespath isn't.

@kmbenitez
Copy link
Author

@kmbenitez kmbenitez commented Sep 13, 2018

Same versions as @winsome. I just replicated the issue with the following requirements.txt

PyMySQL==0.8.1
arrow==0.4.2

and

arrow==0.4.2
PyMySQL==0.8.1

In both cases, the first package was installed into the zip, but the second wasn't.

I was able to update _install_packages (and the call to pip freeze) to use subprocess (introduced in Python 2.4). I'm not sure about the dependency implications though.

@kmbenitez
Copy link
Author

@kmbenitez kmbenitez commented Sep 13, 2018

I created a pull request a while back for another feature, and it appears my commit for the fix on this got pulled into that request. I'm not sure how to separate them to make two separate pull requests for the different features.

@henry034
Copy link

@henry034 henry034 commented Sep 17, 2018

Same here. It will lose some packages due to the revision.

@soapergem
Copy link
Collaborator

@soapergem soapergem commented Sep 17, 2018

Thanks to all reporting this issue. I have verified the bug using the arrow/PyMySQL requirements.txt file. I will test out the subprocess fix and if it works I'll try to get a release out sometime this week.

@soapergem soapergem closed this in 6dc00f3 Sep 19, 2018
@kmbenitez
Copy link
Author

@kmbenitez kmbenitez commented Sep 19, 2018

Thanks! For my future knowledge, as far as I could tell I couldn't create a pull request because I already had one open. What's the right way to do this?

@soapergem
Copy link
Collaborator

@soapergem soapergem commented Sep 19, 2018

@kmbenitez you probably did it correctly - for some reason I didn't see that you had a PR though. Forgive me, as I'm still relatively new to the Python ecosystem, so I may have just overlooked it. In any case, your changes have been merged in, and release v3.2.5 has been published which fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.