★ wanayoo — archive 1999 https://github.com/blockstack/blockstack-browser/issues/242Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design the wallet app #242

Closed
shea256 opened this issue Feb 20, 2017 · 21 comments
Closed

design the wallet app #242

shea256 opened this issue Feb 20, 2017 · 21 comments

Comments

@shea256
Copy link
Member

@shea256 shea256 commented Feb 20, 2017

see #241 for reference

@shea256 shea256 added this to the Release v0.4.0 milestone Feb 20, 2017
@guylepage3 guylepage3 mentioned this issue Feb 20, 2017
27 of 39 tasks complete
@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Feb 20, 2017

@shea256 @larrysalibra will requirements for the wallet be as follows:

  • deposit
  • withdraw
  • backup account
  • restore account
  • delete account
@shea256
Copy link
Member Author

@shea256 shea256 commented Feb 20, 2017

@guylepage3 no, only deposit and withdraw will be present in the wallet.

@shea256
Copy link
Member Author

@shea256 shea256 commented Feb 20, 2017

The backup, restore, and delete account operations will be accessible in the settings app.

@larrysalibra
Copy link
Member

@larrysalibra larrysalibra commented Feb 22, 2017

screen shot 2017-02-22 at 12 39 46 pm

Added the Wallet App in #241 - as part of the design it will also need an icon.

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Feb 22, 2017

@guylepage3 guylepage3 removed this from To Do in Release v0.4.0 - Closed Mar 4, 2017
@guylepage3 guylepage3 added v0.5.0 and removed v0.4.0 labels Mar 4, 2017
@guylepage3 guylepage3 mentioned this issue Mar 4, 2017
34 of 53 tasks complete
@guylepage3 guylepage3 removed this from the Release v0.5.0 milestone Mar 4, 2017
@guylepage3 guylepage3 added backlog and removed v0.5.0 labels Mar 4, 2017
@guylepage3 guylepage3 removed this from To Do in Release v0.5.0 - Closed Mar 4, 2017
@guylepage3 guylepage3 added v0.5.0 and removed backlog labels Mar 7, 2017
@guylepage3 guylepage3 added this to the Release v0.5.0 milestone Mar 7, 2017
@guylepage3 guylepage3 moved this from To Do to Doing in Release v0.5.0 - Closed Mar 7, 2017
@guylepage3 guylepage3 moved this from Doing to To Do in Release v0.5.0 - Closed Mar 7, 2017
@guylepage3 guylepage3 moved this from To Do to Doing in Release v0.5.0 - Closed Mar 8, 2017
@guylepage3 guylepage3 moved this from Doing to To Do in Release v0.5.0 - Closed Mar 9, 2017
@shea256
Copy link
Member Author

@shea256 shea256 commented Mar 24, 2017

@guylepage3 Can we see the older wallet app designs that we put together?

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 24, 2017

definitely.. let me organize them

@guylepage3 guylepage3 added the design label Mar 24, 2017
@shea256
Copy link
Member Author

@shea256 shea256 commented Mar 24, 2017

Requirements

  1. A large balance display that appears on all tabs.
  2. Three tabs:
    1. Activity: list of historical transactions (this will be blank at first)
    2. Receive: displays (a) a bitcoin address (b) a QR code.
    3. Send: displays (a) a "To" field (b) an "Amount" field (c) a "Password" field
@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 24, 2017

screenshot 2017-03-24 18 44 04

screenshot 2017-03-24 18 44 24

screenshot 2017-03-24 18 47 55

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 27, 2017

@shea256 @larrysalibra

Hmm. Question.. Do we want to display the wallet balance in USD or BTC? I've noticed that even Coinbase displays their wallet balance in USD. Seems logical. No?

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 27, 2017

Also, will users be able to send btc to Blockstack ID's or to bitcoin addresses only?

@larrysalibra
Copy link
Member

@larrysalibra larrysalibra commented Mar 28, 2017

Do we want to display the wallet balance in USD or BTC? I've noticed that even Coinbase displays their wallet balance in USD. Seems logical.

Coinbase displays their balance in USD only for US users. If you're a UK user (or other place user) you get you balance in your local currency. To provide a good user experience, we quickly get into questions like: which currency to default to? How does the user change it? How do we choose the default? Geolocation? Browser local settings?

We'd also need to get exchange rate information from a 3rd party API. Which API should we use? Is it free? Can it handle a lot of users? What are the privacy implications for adding that API?

I think for this sprint we should stick to BTC. We can open a ticket to add this feature in the future. My view is that it's not as pressing as our other issues.

Also, will users be able to send btc to Blockstack ID's or to bitcoin addresses only?

It's trivial to implement sending bitcoin to Blockstack IDs (are we still calling them that?). Let's do it.

@larrysalibra
Copy link
Member

@larrysalibra larrysalibra commented Mar 28, 2017

@guylepage3

I replied before looking at your mock ups. I really like how it has the USD price under the BTC value.

Maybe we should do this and for now not give the user a choice of fiat currencies. Most people have a good idea what their local currency to USD exchange rate is anyways. @shea256 what do you think?

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 28, 2017

I think for this sprint we should stick to BTC. We can open a ticket to add this feature in the future. My view is that it's not as pressing as our other issues.

@larrysalibra Sorry this is for design so that I can future-proof a little. Design requires a full requirement capture in order to not waste a design and have to throw it out just because we need to add a new feature. We need to get better at this. If Blockstack was a client I would make us go through an entire creative process. That's how you get decent design. But we do not have that luxury. So in order to streamline (somewhat) we need to gather as many requirements as fast as we can so that we don't throw the baby out with the bathwater.

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 29, 2017

@shea256 @larrysalibra what are we going to call the wallet? any names that come to mind? or what do you think.. simply "wallet"

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 29, 2017

wallet-desktop-dark-landscape 2x
wallet-desktop-dark-landscape2 2x
wallet-desktop-dark-landscape3 2x
wallet-desktop-dark-landscape4 2x
wallet-desktop-dark 2x

@shea256
Copy link
Member Author

@shea256 shea256 commented Mar 29, 2017

Nice work! Love #2 out of 5!

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 29, 2017

#2 has that leather wallet smell. 😂 Lol. It does feel a bit dated to me somehow though. I like the cleanliness of the others personally.

@shea256
Copy link
Member Author

@shea256 shea256 commented Mar 29, 2017

The others are harder on my eyes and not as easy for me to navigate.

@pstan26
Copy link
Member

@pstan26 pstan26 commented Mar 29, 2017

I like 2 out of 5 too. Didn't realize this was also ryan's pick but it is easier on the eyes and has a friendly green. The financial component on this app weighs heavy psychologically -- the black background looks like space and a place where money could be lost, you'll be hard pressed to find a bank that has a black background.

Check out the descriptions from the color wheel pro:

screen shot 2017-03-29 at 5 51 44 pm
screen shot 2017-03-29 at 5 51 54 pm

@guylepage3
Copy link
Contributor

@guylepage3 guylepage3 commented Mar 29, 2017

Oh... Naaarrrrrr.... 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.