★ wanayoo — archive 1999 https://github.com/PowerShell/PowerShell/issues/8155Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify discovering and enabling experimental features #8155

Closed
SteveL-MSFT opened this issue Oct 31, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@SteveL-MSFT
Copy link
Member

commented Oct 31, 2018

Experimental feature flags is new to PSCore6.1. We are starting to have some features implemented behind the experimental flag. Currently, you have to pass -ListAvailable to Get-ExperimentalFeature to all the features and not just the enabled ones. For users new to experimental features, this seems non-obvious and it appears that there are no experimental features which limits how much feedback we can get. I would suggest removing the need for -ListAvailable as the user can easily filter enabled vs disabled ones.

After the user sees the available features, it's not obvious how to update their PowerShell settingsfile to enable the feature. They need to add something like:

            {
                "ExperimentalFeatures": [
                  "PSUseAbbreviationExpansion",
		  "PSImplicitRemotingBatching"
                ]
            }

To their config file. Seems like we need to add support for user config files instead of just system wide. A cmdlet to enable features (which message indicating the features are enabled after restart of PowerShell) as well as disabling features.

Environment data

Name                           Value
----                           -----
PSVersion                      6.2.0-preview.1
PSEdition                      Core
GitCommitId                    6.2.0-preview.1-43-g66a4ab10a9c33d0a1e7daef9a8cb6ba881e8de02
OS                             Darwin 18.0.0 Darwin Kernel Version 18.0.0: Wed Aug 22 20:13:40 PDT 2018; root:xnu-4903.201.2~1/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@vexx32

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

-ListAvailable does seem like an odd choice to have for a command in this context to have, indeed. Agreed that discoverability of experimental features is important if we plan to have them be tested at all.

Do we have a Set-/Enable-/Disable-ExperimentalFeature command? If not, I think we should. 😄

@SteveL-MSFT

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

Currently, we only have the Get, I'm proposing we add Enable and Disable and tweak Get. Also need to add support for default powershell.config.json at user scope since it's currently only supported at system scope.

@vexx32

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

Yep, that'll be very important for experimental feature adoption, I think... having to set things at system scope all the time would probably be a bit of a turn-off.

@SteveL-MSFT

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

@vexx32 enabling experimental features at system scope seems like a bad practice :)

@SteveL-MSFT

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@vexx32 see the RFC I just published for this PowerShell/PowerShell-RFC#148

@daxian-dbw

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

@SteveL-MSFT Can this issue be closed now via #8318?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.