Wrong indentation for passed scriptblocks in pipe sequence (PSUseConsistentIndentation) #1066

felixfbecker · 2018-09-04T10:14:28Z

Steps to reproduce

Get-ChildItem *.yml |
    Get-Content -Raw |
    ConvertFrom-KubeYaml |
    ForEach-Object {
        switch ($_.Metadata.Name) {
            # ...
        }
    } |
	Update-KubeResource

Expected behavior

Should not cause a rule violation, this is the expected formatting

Actual behavior

Formats to:

Get-ChildItem *.yml |
    Get-Content -Raw |
    ConvertFrom-KubeYaml |
    ForEach-Object {
    switch ($_.Metadata.Name) {
        # ...
    }
} |
    Update-KubeResource

Note how the switch is not indented and the closing brace of the scriptblock is on the wrong level, while the next pipeline element is correct.

Environment data

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.1.0-rc.1
PSEdition                      Core
GitCommitId                    6.1.0-rc.1
OS                             Darwin 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.17.1

bergmeister · 2018-11-05T20:51:55Z

Thanks for raising it and sorry for coming back quite late to this. This has annoyed me sometimes as well. I will start to look into this so that we hopefully have a fix in the next version of PSSA

bergmeister · 2018-11-14T07:29:22Z

I had a look at this, a slightly more simplified example for this issue is (the problem is that there is more than 1 line after 1 pipeline)

Get-ChildItem |
    ForEach-Object {
        $_.ToString()
}

I will try to see if I can come up with a fix for this, as far as I can see, pipes are being catered for but the author decided to give them only 'temporary' indentation for the next line after the ppipe because the rule only looks at tokens and therefore does not know when the pipe ends. I will try to see if I can fix this.
@felixfbecker Why do you not expect the correct formatting to be this?

Get-ChildItem *.yml |
    Get-Content -Raw |
        ConvertFrom-KubeYaml |
            ForEach-Object {
                switch ($_.Metadata.Name) {
                    # ...
            }
        } |
	       Update-KubeResource

bergmeister added Issue - Enhancement Area - Formatter labels Sep 12, 2018

bergmeister self-assigned this Nov 5, 2018

bergmeister mentioned this issue Nov 14, 2018

Fix PSUseConsistentIndentationRule to handle pipes correctly when there is a multi-line statement after a pipe and add PipelineIndentation customisation option for it #1102

Merged

6 of 6 tasks complete

bergmeister closed this in #1102 Mar 5, 2019

bergmeister mentioned this issue Mar 27, 2019

1.18.0 - Incorrect indentation of brace after pipe #1187

Closed

PowerShell / PSScriptAnalyzer

Wrong indentation for passed scriptblocks in pipe sequence (PSUseConsistentIndentation) #1066

Wrong indentation for passed scriptblocks in pipe sequence (PSUseConsistentIndentation) #1066

felixfbecker commented Sep 4, 2018 •

edited

bergmeister commented Nov 5, 2018 •

edited

bergmeister commented Nov 14, 2018 •

edited

PowerShell / PSScriptAnalyzer

Join GitHub today

Wrong indentation for passed scriptblocks in pipe sequence (PSUseConsistentIndentation) #1066

Wrong indentation for passed scriptblocks in pipe sequence (PSUseConsistentIndentation) #1066

Comments

felixfbecker commented Sep 4, 2018 • edited

Steps to reproduce

Expected behavior

Actual behavior

Environment data

bergmeister commented Nov 5, 2018 • edited

bergmeister commented Nov 14, 2018 • edited

felixfbecker commented Sep 4, 2018 •

edited

bergmeister commented Nov 5, 2018 •

edited

bergmeister commented Nov 14, 2018 •

edited