| ★ wanayoo — archive 1999 http://www.kernelnotes.org/patch/20-p0779.html | Nouvelle recherche | Portail wanayoo |
|
Bill Hawes (whawes@star.net) Tue Aug 12 02:43:00 1997 |
[Home] [Linux 2.0] [Linux 2.1] [Information] [Software] [Distributions] [Links] |
|
I've found a problem in the 2.0.31 nfsiod code that might explain some of the posted problems with NFS. If one of the nfsiod tasks is awakened by a signal, it fails to unlink its request structure and could possibly corrupt the free list of requests.Similarly, if the task is somehow awakened before its req has been removed, nfsiod clears the request when it loops back to requeue the request, which would corrupt the free list. The present code seems to allow for the possibility of such a wakeup by testing whether slot is non-NULL and doing a continue.
The attached patch checks the free_list immediately upon awakening, and if it finds the request still queued prints a warning and unqueues it. The nfsiod tasks can then continue safely.
If you're using NFS under 2.0.31 (and especially if you've had crash problems), please test this and let me know if the warning message appears.